Added Search page - #276
Conversation
|
Warning Review limit reached
Next review available in: 49 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
WalkthroughAdds a parked Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@website/modules/`@apostrophecms/search/views/index.html:
- Around line 16-19: Update the search-term display condition and rendered value
in the template’s search-results block to use data.query.q instead of
data.query.search, so the parameter submitted by the /search form appears in the
“Showing Results for …” message.
In `@website/modules/asset/ui/src/index.scss`:
- Line 29: Update the SCSS import in the stylesheet to reference the canonical
search partial name without the underscore, while preserving the existing
relative import path and extensionless resolution.
In `@website/modules/home-simplified/views/page.html`:
- Around line 30-33: Update the search form identified by id="search-form" to
replace the arrow span with a button element whose type is submit, preserving
the arrow’s existing appearance and placement so it provides an operable submit
control.
In `@website/public/css/home-simplified/home-simplified.css`:
- Around line 250-259: Update the `.sgo` search-arrow element in the
home-simplified page markup to a `<button type="submit" class="sgo">` so it
submits the GET form without JavaScript; preserve the arrow content and add CSS
resets for button defaults while retaining the existing `.sgo` layout, color,
transition, and focus-within behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 97dcd0dd-3152-40d3-a056-c7229757a62b
📒 Files selected for processing (8)
website/modules/@apostrophecms/page/index.jswebsite/modules/@apostrophecms/search/views/index.htmlwebsite/modules/asset/ui/src/index.scsswebsite/modules/asset/ui/src/scss/_search.scsswebsite/modules/home-simplified/public/js/home-simplified.jswebsite/modules/home-simplified/views/page.htmlwebsite/modules/testimonials/index.jswebsite/public/css/home-simplified/home-simplified.css
💤 Files with no reviewable changes (2)
- website/modules/home-simplified/public/js/home-simplified.js
- website/modules/testimonials/index.js
| <form class="ca-search" id="search-form" method="GET" action="/search" data-search-form> | ||
| <label for="search-input" class="sr-only">Search</label> | ||
| <svg class="sicon" width="22" height="22" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2.2" stroke-linecap="round"><circle cx="11" cy="11" r="7"></circle><line x1="21" y1="21" x2="16.2" y2="16.2"></line></svg> | ||
| <input type="text" id="search-input" placeholder="Find case studies, testimonials, and more"> | ||
| <input type="text" id="search-input" name="q" placeholder="Find case studies, testimonials, and more"> |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Provide an operable submit control.
The arrow is a <span>, so clicking it does not submit the form. Replace it with a submit button.
Proposed fix
- <span class="sgo">→</span>
+ <button type="submit" class="sgo" aria-label="{{ __('Submit search') }}">→</button>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@website/modules/home-simplified/views/page.html` around lines 30 - 33, Update
the search form identified by id="search-form" to replace the arrow span with a
button element whose type is submit, preserving the arrow’s existing appearance
and placement so it provides an operable submit control.
| font-size: 22px; | ||
| color: #6B6B6B; | ||
| display: inline-block; | ||
| flex: 0 0 auto; | ||
| transition: color .2s ease; | ||
| transition: transform .3s cubic-bezier(.16,1,.3,1), color .3s ease; | ||
| } | ||
|
|
||
| .ca-search:focus-within .sgo { | ||
| color: #00897B; | ||
| transform: translateX(10px) rotate(45deg); |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Make the search arrow a real submit control.
website/modules/home-simplified/views/page.html renders .sgo as a <span>. With the JavaScript redirect removed, clicking or tapping this visible arrow does not submit the GET form; the mobile change now exposes the same non-interactive affordance on small screens. Replace it with <button type="submit" class="sgo">→</button> and reset the button styles as needed.
Also applies to: 457-459
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@website/public/css/home-simplified/home-simplified.css` around lines 250 -
259, Update the `.sgo` search-arrow element in the home-simplified page markup
to a `<button type="submit" class="sgo">` so it submits the GET form without
JavaScript; preserve the arrow content and add CSS resets for button defaults
while retaining the existing `.sgo` layout, color, transition, and focus-within
behavior.
3 participants
Added a dedicated Search page at
/search, including parked-page configuration, results and pagination rendering, responsive styling, and empty-state handling. Updated the homepage search form to submit queries via GET, removed obsolete JavaScript redirection, and excluded testimonials from search indexing. Also refined homepage spacing, CTA styling, and mobile search indicator behavior.